Oh-x-accounts #65
Closed
Oh-x-accounts #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the ticket?
OH-X-ACCOUNTS
Fix styling on accounts page and
Link to Ticket: #64
What did I do?
Make one page
fix side image
fix header
add state
How did I test it? Document test cases here.
look at figma, look at localhost:3000/accounts
console.log(state) when updating
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
Create User endpoint might need more parameters than email/password when sending request on Sign Up button.
Screenshots